Adding state parser utility that can be used for retrieving and modifying worker states#1278
Open
gokulavasan wants to merge 1 commit intomainfrom
Open
Adding state parser utility that can be used for retrieving and modifying worker states#1278gokulavasan wants to merge 1 commit intomainfrom
gokulavasan wants to merge 1 commit intomainfrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1278
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cb10f71 with merge base 958eeb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
andrewkho
reviewed
Jun 25, 2024
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class StateParserUtil: |
Contributor
There was a problem hiding this comment.
can we keep these as functions? I'm not sure of the benefit of having a class here
andrewkho
suggested changes
Jun 25, 2024
Contributor
andrewkho
left a comment
andrewkho
left a comment
There was a problem hiding this comment.
I think pure functions are easier to reason about and harder to screw up, let me know if there's other reasons you want to keep them in a class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Allows users to get the worker states out of the state dict. It can be used if users want to modify the state offline. Starts off with very preliminary set of methods aimed at supporting usecases where number of workers need to change.
Test Plan: Unit tests
Reviewers:
Subscribers:
Tasks:
Tags:
Please read through our contribution guide prior to
creating your pull request.
Fixes #{issue number}
Changes