Skip to content

fix: Set log level from config when not passed in cli args#32

Open
Sangamesh26 wants to merge 1 commit intometa-llama:mainfrom
Sangamesh26:fix/set-log-from-config
Open

fix: Set log level from config when not passed in cli args#32
Sangamesh26 wants to merge 1 commit intometa-llama:mainfrom
Sangamesh26:fix/set-log-from-config

Conversation

@Sangamesh26
Copy link
Copy Markdown
Contributor

@Sangamesh26 Sangamesh26 commented Jul 10, 2025

What does this PR do?

  • This PR addresses the issue where the log level specified in the configuration file was not being respected when the CLI log level was not provided. The log level will now correctly default to the value from the configuration, rather than always defaulting to INFO.
  • It also resolves missing import statements in the code.

Closes #29

Test Plan

  • Verified that all existing tests pass successfully.
  • Added a new unit test to validate that the log level is correctly set from the configuration file when not provided via CLI.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues in logging framework

2 participants

@Sangamesh26 @facebook-github-bot