Skip to content

Fix memory leak in todo_list example #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meszmate merged 1 commit into from
Feb 13, 2026
Merged

Fix memory leak in todo_list example #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions examples/todo_list.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const Model = struct {
list: zz.List(Todo),
input_mode: bool,
input: zz.TextInput,
persistent_allocator: std.mem.Allocator,
owned_titles: std.array_list.Managed([]const u8),

const Todo = struct {
id: u32,
Expand All @@ -22,6 +24,8 @@ const Model = struct {
self.list = zz.List(Todo).init(ctx.persistent_allocator);
self.list.multi_select = true;
self.list.height = 10;
self.persistent_allocator = ctx.persistent_allocator;
self.owned_titles = std.array_list.Managed([]const u8).init(ctx.persistent_allocator);

// Add some sample items
const Item = zz.List(Todo).Item;
Expand Down Expand Up @@ -53,7 +57,16 @@ const Model = struct {
const new_id: u32 = @intCast(self.list.items.items.len + 1);
const title = ctx.persistent_allocator.dupe(u8, self.input.getValue()) catch return .none;
const Item = zz.List(Todo).Item;
self.list.addItem(Item.init(.{ .id = new_id, .done = false }, title)) catch {};
self.list.addItem(Item.init(.{ .id = new_id, .done = false }, title)) catch {
ctx.persistent_allocator.free(title);
return .none;
};
self.owned_titles.append(title) catch {
_ = self.list.items.pop();
self.list.updateFilter() catch {};
ctx.persistent_allocator.free(title);
return .none;
};
self.input.setValue("") catch {};
}
self.input_mode = false;
Expand Down Expand Up @@ -90,7 +103,8 @@ const Model = struct {
if (self.list.cursor >= visible.len) return;

const item_idx = visible[self.list.cursor];
_ = self.list.items.orderedRemove(item_idx);
const removed = self.list.items.orderedRemove(item_idx);
self.freeOwnedTitle(removed.title);

// Update filter to rebuild filtered_indices
self.list.updateFilter() catch {};
Expand All @@ -110,6 +124,16 @@ const Model = struct {
self.list.items.items[item_idx].value.done = !self.list.items.items[item_idx].value.done;
}

fn freeOwnedTitle(self: *Model, title: []const u8) void {
for (self.owned_titles.items, 0..) |owned, i| {
if (owned.ptr == title.ptr and owned.len == title.len) {
_ = self.owned_titles.orderedRemove(i);
self.persistent_allocator.free(owned);
return;
}
}
}

pub fn view(self: *const Model, ctx: *const zz.Context) []const u8 {
var title_style = zz.Style{};
title_style = title_style.bold(true);
Expand Down Expand Up @@ -255,6 +279,10 @@ const Model = struct {
}

pub fn deinit(self: *Model) void {
for (self.owned_titles.items) |title| {
self.persistent_allocator.free(title);
}
self.owned_titles.deinit();
self.list.deinit();
self.input.deinit();
}
Expand Down