Updated verify_jws.sh now able to verify#75
Open
mholschbach wants to merge 1 commit intomesur-io:mainfrom
Open
Updated verify_jws.sh now able to verify#75mholschbach wants to merge 1 commit intomesur-io:mainfrom
mholschbach wants to merge 1 commit intomesur-io:mainfrom
Conversation
OR13
approved these changes
Dec 11, 2023
OR13
reviewed
Dec 11, 2023
|
|
||
| # Create a temporary file for the binary signature | ||
| signature_file=$(mktemp) | ||
| echo -n "$signature_base64" | base64 -d > $signature_file |
There was a problem hiding this comment.
are we sure the binary signature is not der encoded here?
Author
There was a problem hiding this comment.
If I still remember it correctly then it is DER after the decoding from Base64.
|
@mprorock needs review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes to the verify_jws.sh allow successful validation of jws created by sign_jws.sh