Add riscv64 build, and make target list more explicit#110
Merged
messense merged 4 commits intomessense:mainfrom Jan 21, 2026
Merged
Add riscv64 build, and make target list more explicit#110messense merged 4 commits intomessense:mainfrom
messense merged 4 commits intomessense:mainfrom
Conversation
Contributor
Author
|
I've added a revertme patch that disables package upload, just so we can test the build run. Otherwise, armv7 fails because the package is already there and we never get to the other builds (namely, the riscv64 one). |
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
e6ed213 to
31af1c2
Compare
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Contributor
Author
|
The revertme patch is gone now. I've added a separate one for the musllinux cross case, which also tweaks the upload step to be consistent with linux cross. |
Contributor
Author
|
@messense looking at the musllinux-cross failure for riscv64, I think it might need some extra tooling installed to get it working. I think in this case it's safer to only build for riscv64 with glibc for now. What are your thoughts? |
Owner
|
Sounds good. |
messense
reviewed
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maturin supports riscv64 cross-compile, so add that to the build matrix. However, first make things more explicit about which rustc targets to use for each architecture.
When I was testing this out on my fork, I found that just specifying
riscv64as a target didn't work, but being very clear about which compiler target matched to each architecture did, so I've added that.