Skip to content

Added support for .net framework 3.5 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cadsjo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for .net framework 3.5 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MessageBird/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ private string GetAddContactsToGroupQuery(IEnumerable<string> contactIds)
parameters.Add("ids[]=" + contactId);
}

return string.Join("&", parameters);
return string.Join("&", parameters.ToArray());
}

public void RemoveContactFromGroup(string groupId, string contactId)
Expand Down
6 changes: 5 additions & 1 deletion MessageBird/MessageBird.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net40;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net35;net40;netstandard2.0</TargetFrameworks>
<Product>MessageBird</Product>
<Title>MessageBird</Title>
<Company>MessageBird</Company>
Expand All @@ -11,6 +11,10 @@
<AssemblyVersion>1.4.1.0</AssemblyVersion>
</PropertyGroup>

<!-- Conditionally obtain references for the .NET Framework 3.5 target -->
<ItemGroup Condition=" '$(TargetFramework)' == 'net35' ">
</ItemGroup>

<!-- Conditionally obtain references for the .NET Framework 4.0 target -->
<ItemGroup Condition=" '$(TargetFramework)' == 'net40' ">
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion MessageBird/Utilities/Validation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class ParameterValidator
{
public static void IsNotNullOrWhiteSpace(string param, string paramName)
{
if (String.IsNullOrWhiteSpace(param))
if (string.IsNullOrEmpty(param) || param.Trim() == "")
{
throw new ArgumentException("Invalid string parameter, cannot be null, empty, or contain only whitespace", paramName);
}
Expand Down