Fixing typo: OpticalElement(lc0, label=lenssystem) ... label -> name.

[martin357]

It was causing error:
Change property: numrays
Running the Python command 'CreateSystemCommand' failed:
Traceback (most recent call last):
File "/home/martin/.FreeCAD/Mod/pyrate/freecad/PyrateWorkbench/Commands_OpticalSystem.py", line 76, in Activated
osobs.initFromGivenOpticalSystem(osobs.initDemoSystem())
File "/home/martin/.FreeCAD/Mod/pyrate/freecad/PyrateWorkbench/Observer_OpticalSystem.py", line 249, in initDemoSystem
elem = OpticalElement(lc0, label="lenssystem")

[joha2]

Hi @martin357 Thanks for your PR. Your contribution is very appreciated. I would suggest to postpone it, until we refactored our interface. This has the following reasons:

• First, at the moment we are rewriting all constructors to accept only certain dicts and therefore the direct initialization of OpticalSystem via the constructor is considered as deprecated.
• Second, the FreeCAD interface is broken since our last large refactoring and is to be done after refactoring the constructors.

For the refactoring see the branch unification_constructors in the @joha2 fork. Therefore, it may take a little time to accept your PR.

Best wishes
Johannes

[martin357]

Hi @joha2 Thanks for your reply. I did notice that this seem to be only the first problem to jump at me.
I'm looking forward to see it working again with to latest FreeCAD version.

Best regards,
Martin.