Revert "feat(ui): add SNR, RSSI, hops info for messages"

[danditomaso]

Reverts #963

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
web-test	Ready	Preview	Comment	Dec 2, 2025 2:12pm

[Copilot]

Pull request overview

This PR reverts PR #963, which previously added SNR (Signal-to-Noise Ratio), RSSI (Received Signal Strength Indicator), hops, and MQTT indicator features to message displays. The revert cleanly removes these features across all layers of the application.

• Removes telemetry fields (rxSnr, rxRssi, hops, viaMqtt) from message type definitions and packet metadata
• Removes UI components displaying message routing information (cloud icon for MQTT, hops counter, SNR/RSSI display)
• Reverts documentation changes about cross-platform visual consistency guidelines

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/web/src/core/stores/messageStore/types.ts	Removes rxSnr, rxRssi, viaMqtt, and hops fields from MessageBase interface
packages/web/src/core/stores/messageStore/messageStore.test.ts	Removes the four telemetry fields from all test message fixtures
packages/web/src/core/dto/PacketToMessageDTO.ts	Removes telemetry field properties, constructor assignments, and return values
packages/web/src/components/PageComponents/Messages/MessageItem.tsx	Removes MQTT cloud icon tooltip and hops/SNR/RSSI display components
packages/web/CONTRIBUTING.md	Removes cross-platform visual consistency guidelines from contributor tips
packages/core/src/utils/transform/decodePacket.ts	Removes hardcoded telemetry fields (all set to 0/false) from packet dispatch calls
packages/core/src/types.ts	Removes hops, rxRssi, rxSnr, and viaMqtt from PacketMetadata interface
packages/core/src/meshDevice.ts	Removes calculation and assignment of telemetry fields in packet metadata

Comments suppressed due to low confidence (1)

packages/web/src/components/PageComponents/Messages/MessageItem.tsx:256

• The removed code has a logic bug with the conditional rendering. The expression (message.hops && (...JSX...)) || (message.rxSnr && message.rxRssi && (...JSX...)) has two issues:

1. When message.hops is 0 (a valid hop count), it would be falsy and not render the hops display
2. The || operator means only one display would ever render, not both - if hops is truthy, the SNR/RSSI display would never show even if those values are present

While this is being removed, it's worth documenting for reference if this feature is re-implemented.

        </div>
      </div>
      {/* Actions Menu Placeholder */}
      {/* <div className="absolute top-1 right-1">
        <MessageActionsMenu onReply={() => console.log("Reply")} />
       </div> */}
    </li>
  );
};

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.