feat: service decoupling

[jamesarich]

Overview

This PR implements a major architectural refactor to decouple the application layers, moving the project toward Modern Android Development (MAD) best practices and Kotlin Multiplatform (KMP) readiness. Business logic has been extracted from the :app module into specialized core modules, and platform-specific radio logic is now abstracted behind clean interfaces.

Key Changes

• Layer Separation: Established a clear hierarchy between :core:model (KMP models), :core:repository (interfaces), :core:domain (business logic/use cases), and :core:data/:core:service (implementations).
• Interface Abstraction: Introduced RadioController and ServiceRepository to decouple the UI from AIDL and background service lifecycle.
• Use Case Pattern: Migrated complex workflows (e.g., sending messages, admin actions) into dedicated Use Cases for improved readability and testability.
• Model Promotion: Promoted core domain models (Node, Message, Position) to the :core:model module.
• Reactivity: Standardized mesh event handling using StateFlow and SharedFlow across all layers.

Regressions Fixed During Review

• Node Persistence: Restored database synchronization in NodeManagerImpl (previously only updating in-memory).
• Data Integrity: Fixed missing publicKey mapping in NodeWithRelations to ensure PKI features remain functional.
• Packet ID Stability: Fixed a bug in SendMessageUseCase where packet IDs could be zero or negative.
• Test Suite: Fixed and verified MeshDataHandlerTest.kt and SendMessageWorkerTest.kt to match the new constructor signatures.

[codecov]

Codecov Report

❌ Patch coverage is 3.84615% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.12%. Comparing base (8c6bd8a) to head (3b39fa4).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...a/com/geeksville/mesh/service/ServiceBroadcasts.kt	2.38%	41 Missing ⚠️
...h/repository/radio/AndroidRadioInterfaceService.kt	0.00%	19 Missing ⚠️
...eeksville/mesh/service/AndroidMeshWorkerManager.kt	0.00%	10 Missing ⚠️
...ville/mesh/service/MeshServiceNotificationsImpl.kt	0.00%	8 Missing ⚠️
...le/mesh/repository/radio/NordicBleInterfaceSpec.kt	0.00%	4 Missing ⚠️
...geeksville/mesh/service/AndroidAppWidgetUpdater.kt	0.00%	4 Missing ⚠️
...com/geeksville/mesh/ui/sharing/ChannelViewModel.kt	0.00%	4 Missing ⚠️
...main/java/com/geeksville/mesh/model/UIViewModel.kt	0.00%	3 Missing ⚠️
...geeksville/mesh/ui/connections/ScannerViewModel.kt	0.00%	3 Missing ⚠️
...sville/mesh/repository/radio/NordicBleInterface.kt	60.00%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #4685      +/-   ##
=========================================
- Coverage   15.18%   8.12%   -7.07%     
=========================================
  Files          83      64      -19     
  Lines        4353    2499    -1854     
  Branches      734     289     -445     
=========================================
- Hits          661     203     -458     
+ Misses       3566    2264    -1302     
+ Partials      126      32      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull request overview

This PR implements a major architectural decoupling refactor for the Meshtastic Android app, moving business logic out of the :app module into specialized core modules and introducing clean interfaces for platform-specific radio and service logic.

Changes:

• Introduced a new :core:repository module containing interface definitions (NodeRepository, ServiceRepository, RadioConfigRepository, MessageFilter, MessageQueue, etc.) to decouple business logic from implementation details.
• Promoted core domain models (Node, Message, Reaction, NodeSortOption, ContactSettings, etc.) from core.database.model to the core.model module for KMP readiness.
• Replaced direct AIDL meshService calls with RadioController abstractions throughout ViewModels, use cases, and firmware update handlers.

Reviewed changes

Copilot reviewed 250 out of 250 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
settings.gradle.kts	Registers the new :core:repository module
core/repository/src/commonMain/...	New interface definitions for the repository layer
core/model/src/...	Promoted domain models and new model types
core/data/src/...	Implementations renamed with Impl suffix to separate from interfaces
core/domain/src/...	Use cases updated to use core.repository interfaces
core/service/src/...	Service implementations refactored; MessageFilterImpl replaces MessageFilterService
feature/*/src/...	Feature-layer ViewModels and components updated to use new interfaces and model locations
app/src/...	App-level service classes refactored to use RadioController and new repository interfaces

Comments suppressed due to low confidence (2)

feature/firmware/src/main/kotlin/org/meshtastic/feature/firmware/ota/Esp32OtaUpdateHandler.kt:1

• A bare CoroutineScope(Dispatchers.IO) is created without any lifecycle management. This scope will never be cancelled if the handler is destroyed or if an exception occurs, which can lead to coroutine leaks. The existing Esp32OtaUpdateHandler class should have its own managed CoroutineScope injected or stored as a member, similar to how other handlers in this codebase (e.g. MeshLocationManager) maintain a private var scope that is replaced via a start(scope: CoroutineScope) method.
  core/repository/src/commonMain/kotlin/org/meshtastic/core/repository/MeshConnectionManager.kt:1
• Similar to MeshServiceNotifications, the return type Any is too broad and erases type safety. The same recommendation applies: use a platform-neutral type, Unit, or move the method out of the shared interface.