Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
+ Coverage 15.18% 16.03% +0.85%
==========================================
Files 83 80 -3
Lines 4353 4122 -231
Branches 734 700 -34
==========================================
Hits 661 661
+ Misses 3566 3335 -231
Partials 126 126 ☔ View full report in Codecov by Sentry. |
jamesarich
force-pushed
the
feat/screenshot-testing
branch
2 times, most recently
from
a530834 to
5caa28f
Compare
Integrate the experimental Android screenshot testing plugin into the `core:ui` module. This includes initial visual regression tests for Alert components and updates to the CI workflow for automated validation. - core/ui: Add `AlertScreenshotTest` and screenshot test dependencies - gradle.properties: Enable `android.experimental.enableScreenshotTest` - libs.versions.toml: Add `com.android.compose.screenshot` plugin and validation API - reusable-check.yml: Add screenshot validation tasks to GitHub Actions workflow
Move various informational UI components from the node feature module to the core UI module to improve reusability across the application. Add a comprehensive screenshot testing suite for core components. - Relocate ChannelInfo, DistanceInfo, ElevationInfo, HopsInfo, IconInfo, LastHeardInfo, SatelliteCountInfo, and TelemetryInfo to `org.meshtastic.core.ui.component`. - Add `ComponentScreenshotTest` in `core:ui` along with baseline reference images for battery, signal, node chips, and other UI elements. - Remove unused `ClickableTextField` from `core:ui`. - Update `CompassBottomSheet` to use the relocated components.
Relocate messaging and node-related UI components from feature modules to the shared core:ui module to improve reusability across the project. Enable the screenshot testing plugin and add comprehensive baseline tests for shared components. - **feature/messaging**: Move `MessageItem`, `MessageActions`, `MessageBubble`, and `Reaction` components to core:ui. - **feature/node**: Move `NodeItem`, `NodeStatusIcons`, `InfoCard`, and `CooldownIconButton` to core:ui. - **core/ui**: Add new screenshot tests for `MainAppBar`, `NodeItem`, `MessageItem`, and various common UI components. - **build.gradle.kts**: Configure the screenshot testing plugin and dependencies for node and messaging feature modules. - Update imports and references across the codebase to reflect relocated components.
jamesarich
force-pushed
the
feat/screenshot-testing
branch
from
5caa28f to
a5be7fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces screenshot testing to the
core/uimodule and refactors several UI components for broader accessibility and improved modularity. The changes also include workflow updates to support the new screenshot tests and clean up of code for consistency.Testing and Build System Enhancements:
core/uimodule by enabling experimental screenshot testing and including required dependencies incore/ui/build.gradle.kts. [1] [2].github/workflows/reusable-check.yml) to allow conditional execution of screenshot tests for different flavors (Google and F-Droid). [1] [2]Component Refactoring and Relocation:
CooldownIconButton,DeliveryInfoDialog,InfoCard,MessageActions,MessageActionsBottomSheet,MessageBubble,MessageItem,NodeItem) from feature-specific modules tocore/ui/componentfor better reuse and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]API Accessibility Improvements:
internaltopublic(e.g.,DrawableInfoCard,ReactionButton,ReplyButton,MessageStatusButton,MessageActions,MessageItem,MessageItemPreview,getMessageBubbleShape, cooldown constants), making them accessible outside their original modules. [1] [2] [3] [4] [5] [6] [7] [8]Code Cleanup and Consistency:
ClickableTextFieldcomponent fromcore/ui/component.NodeItem). [1] [2] [3]These changes collectively improve test coverage, code organization, and the public API surface for UI components.