DR2-112 | Secure app method #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #193 +/- ##
===========================================
+ Coverage 96.39% 96.44% +0.05%
===========================================
Files 35 35
Lines 665 676 +11
===========================================
+ Hits 641 652 +11
Misses 24 24
|
nefrob
reviewed
Mar 18, 2023
| _SUCCESS_DETAILS = _("SMS message with MFA code has been sent.") | ||
|
|
||
| def dispatch_message(self) -> DispatchResponse: | ||
| def dispatch_message(self, url_name: Optional[str] = None) -> DispatchResponse: |
There was a problem hiding this comment.
If we don't care about the args here maybe this would be better:
Suggested change
| def dispatch_message(self, url_name: Optional[str] = None) -> DispatchResponse: | |
| def dispatch_message(self, *args, **kwargs) -> DispatchResponse: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.