Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the IP lookup logging helper so Sidekiq jobs and related lookup classes can resolve it reliably under Zeitwerk autoloading.
The previous implementation added
ip_lookup_logby reopeningLocationsdirectly, which is not a stable autoload target. In some runtime paths,especially background jobs, that method could be missing and IP lookup would fail when logging was invoked.
Changes
Locations::LoggingHelper.ip_lookup_logLocations::LoggingHelperFiles Changed
app/jobs/regular/locations/ip_location_lookup.rblib/locations/geo_location_builder.rblib/locations/geo_names_client.rblib/locations/geo_names_granularity_picker.rblib/locations/logging_helper.rbspec/lib/locations/logging_helper_spec.rbVerification
bin/rspec plugins/discourse-locations/spec/lib/locations/logging_helper_spec.rb