FIX: various follow-up issue resolutions since maintenance release#158
Merged
FIX: various follow-up issue resolutions since maintenance release#158
Conversation
Owner
merefield
commented
Feb 26, 2026
- Strengthened the user-card system spec to assert rendered location label text (city), not just element presence.
- Added the required blank line after the magic comment in the location visibility spec for RuboCop compliance.
- Strengthened the profile-page system spec to assert formatted location text (city, country) in the visible label.
- Hardened profile website links to always include noopener noreferrer with target="_blank" while preserving nofollow/ugc behavior logic.
- Bumped the plugin version in plugin.rb from 7.1.7 to 7.1.8.
There was a problem hiding this comment.
Pull request overview
This PR addresses several follow-up fixes after a maintenance release by tightening system specs around rendered location text, ensuring RuboCop compliance in a spec file, hardening external profile website links, and bumping the plugin version.
Changes:
- Strengthen system specs to assert actual rendered location label text on the profile page (city + country) and user card (city).
- Add a blank line after the frozen string literal magic comment for RuboCop compliance.
- Ensure profile website links always include
rel="noopener noreferrer"alongside existingnofollow/ugclogic, and bump plugin version to 7.1.8.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/system/user_profile_location_visibility_spec.rb | Tightens assertions to validate rendered location label text and adds RuboCop-required blank line. |
| assets/javascripts/discourse/components/replace-location.gjs | Hardens target="_blank" website link rel attribute to always include noopener noreferrer while preserving nofollow/ugc behavior. |
| plugin.rb | Bumps plugin version from 7.1.7 to 7.1.8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.