Skip to content

FIX: various follow-up issue resolutions since maintenance release#158

Merged
merefield merged 5 commits intomainfrom
fix_review_followup
Feb 26, 2026
Merged

FIX: various follow-up issue resolutions since maintenance release#158
merefield merged 5 commits intomainfrom
fix_review_followup

Conversation

@merefield
Copy link
Owner

  • Strengthened the user-card system spec to assert rendered location label text (city), not just element presence.
  • Added the required blank line after the magic comment in the location visibility spec for RuboCop compliance.
  • Strengthened the profile-page system spec to assert formatted location text (city, country) in the visible label.
  • Hardened profile website links to always include noopener noreferrer with target="_blank" while preserving nofollow/ugc behavior logic.
  • Bumped the plugin version in plugin.rb from 7.1.7 to 7.1.8.

@merefield merefield changed the title FIX: various FIX: various follow-up issues since maintenance release Feb 26, 2026
@merefield merefield changed the title FIX: various follow-up issues since maintenance release FIX: various follow-up issue resolutions since maintenance release Feb 26, 2026
@merefield merefield requested a review from Copilot February 26, 2026 15:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses several follow-up fixes after a maintenance release by tightening system specs around rendered location text, ensuring RuboCop compliance in a spec file, hardening external profile website links, and bumping the plugin version.

Changes:

  • Strengthen system specs to assert actual rendered location label text on the profile page (city + country) and user card (city).
  • Add a blank line after the frozen string literal magic comment for RuboCop compliance.
  • Ensure profile website links always include rel="noopener noreferrer" alongside existing nofollow/ugc logic, and bump plugin version to 7.1.8.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
spec/system/user_profile_location_visibility_spec.rb Tightens assertions to validate rendered location label text and adds RuboCop-required blank line.
assets/javascripts/discourse/components/replace-location.gjs Hardens target="_blank" website link rel attribute to always include noopener noreferrer while preserving nofollow/ugc behavior.
plugin.rb Bumps plugin version from 7.1.7 to 7.1.8.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@merefield merefield merged commit c285ca5 into main Feb 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants