update 'get_item_plaintext' URL to the latest version#94
Open
ruoyu-lu wants to merge 1 commit intomeraki-analytics:masterfrom
Open
update 'get_item_plaintext' URL to the latest version#94ruoyu-lu wants to merge 1 commit intomeraki-analytics:masterfrom
ruoyu-lu wants to merge 1 commit intomeraki-analytics:masterfrom
Conversation
Member
|
Is it necessary to remove the version from the string and always use the latest? That isn't desirable behavior so hopefully it's not necessary. |
Author
|
I just saw that as of version 14.15, the official filename has changed from 'main.stringtable.json' to 'lol.stringtable.json', which will prevent the current project from pulling the file, so I think it's fine to just use the latest version of json |
|
isn't it already fixed here anyway? so there is a room to choose version for the plaintext but not for the items themselves as far as I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_item_plaintext function previously utilized an outdated version in its URL path, which led to failures when attempting to retrieve item JSON data files. The filename in the latest version is lol.stringtable.json. This update modifies the URL to align with the newest version, ensuring successful data retrieval.