Draft
Conversation
memoriesadrift
requested changes
May 18, 2021
Owner
memoriesadrift
left a comment
memoriesadrift
left a comment
There was a problem hiding this comment.
Update the readme to include the dependency you added, will test soon!
peter-gy
reviewed
May 18, 2021
Collaborator
peter-gy
left a comment
peter-gy
left a comment
There was a problem hiding this comment.
Tested on iPhone Pro 12 Max, and the feature does not work as expected. The application fails to launch. I would say let's postpone this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried implementing persistent storage in a simple way.
The implementation on this branch should be working, however I am unable to test it in Chrome.
Pleas pull this and try it out on an emulator/real hardware.
If it does not work we can scrap it, we should not invest tooo much time on this