-
Notifications
You must be signed in to change notification settings - Fork 149
feat: update tutorials for Membrane API Gateway #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Removed obsolete `membrane.sh` script for REST tutorial. - Enhanced advanced, JSON, and XML tutorials with clearer starting instructions and feature descriptions. - Added new SOAP tutorial, including introductory documentation, configuration (`10-Sample-SOAP-Service.yaml`), and example script (`invoke-sample-soap-service.sh`). - Fixed command inconsistency in `10-PathParameters.yaml`.
- Clarify usage details in `10-Sample-SOAP-Service.yaml`. - Add initial reference to `.yaml` file in the tutorial's `README.md`.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR updates tutorial documentation and adds a new SOAP tutorial module. Changes include standardizing startup instructions across advanced tutorials, restructuring README files for the advanced, JSON, and XML tutorials, introducing a complete SOAP tutorial with configuration file and invocation script, and removing the membrane.sh shell script from the REST tutorials folder. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
distribution/tutorials/xml/README.md (1)
11-13: Consider removing or relocating the TBD section.The TBD section in user-facing tutorial documentation may create confusion or appear unpolished to users. Consider one of these alternatives:
- Remove the TBD section until XSLT transformation content is ready
- Track it internally (e.g., in a GitHub issue) instead of exposing it in tutorials
- If you want to indicate planned features, rephrase it more positively: "Additional topics coming soon: XSLT transformation"
Option to remove TBD section
- - -## TBD: - -- XSLT transformation
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
distribution/tutorials/advanced/10-PathParameters.yamldistribution/tutorials/advanced/README.mddistribution/tutorials/json/README.mddistribution/tutorials/rest/membrane.shdistribution/tutorials/soap/10-Sample-SOAP-Service.yamldistribution/tutorials/soap/README.mddistribution/tutorials/soap/invoke-sample-soap-service.shdistribution/tutorials/xml/README.md
💤 Files with no reviewable changes (1)
- distribution/tutorials/rest/membrane.sh
🧰 Additional context used
🪛 Shellcheck (0.11.0)
distribution/tutorials/soap/invoke-sample-soap-service.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (3)
distribution/tutorials/xml/README.md (1)
1-8: Well-structured tutorial introduction - referenced file confirmed.The XML tutorial introduction is clear and well-organized. The reference to 10-JSON-to-XML.yaml is valid and the file exists in the xml tutorials directory.
distribution/tutorials/advanced/README.md (1)
3-15: Excellent tutorial restructuring with clear prerequisites and starting point.The changes improve the tutorial by:
- Using the full product name "Membrane API Gateway" for clarity
- Establishing a clear prerequisite (Getting Started tutorial)
- Providing a specific starting point (10-PathParameters.yaml)
- Maintaining consistency with the JSON and XML tutorial structure
The Getting Started tutorial path reference is correct.
distribution/tutorials/advanced/10-PathParameters.yaml (1)
8-8: Verify that membrane.sh is accessible from the advanced directory.The startup instruction now uses
./membrane.shas a relative path. Given that the PR removesdistribution/tutorials/rest/membrane.sh, please confirm that:
- The membrane.sh script exists in the
distribution/tutorials/advanced/directory, or- Users are expected to run this command from a different working directory
This ensures the tutorial instructions work correctly for users.
- Clarify usage details in `10-Sample-SOAP-Service.yaml`. - Add initial reference to `.yaml` file in the tutorial's `README.md`.
… tutorials-soap-and-readmes
|
This pull request needs "/ok-to-test" from an authorized committer. |
|
/ok-to-test |
membrane.shscript for REST tutorial.10-Sample-SOAP-Service.yaml), and example script (invoke-sample-soap-service.sh).10-PathParameters.yaml.Summary by CodeRabbit
Documentation
New Features
✏️ Tip: You can customize this high-level summary in your review settings.