Skip to content

Avoid hardcoded 'register_user' word, next release of kisee may have … #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienPalard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid hardcoded 'register_user' word, next release of kisee may have … #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 1 addition & 33 deletions pasee/users/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
from typing import List, Tuple
from urllib.parse import parse_qs

from aiohttp import web, ClientSession
from aiohttp import web

from pasee import Unauthorized
from pasee.serializers import serialize
from pasee.identity_providers.utils import get_identity_provider_with_capability
from pasee.vendor import coreapi
from pasee import utils
from pasee.groups.utils import is_root
Expand All @@ -37,33 +36,6 @@ async def _cached(*args, **kwargs):
return wrapper


@cached()
async def find_register_user_provider(
request: web.Request,
): # pragma: no cover # needs a running kisee
"""If an identity provider has the capability "register_user", hit its
"register_user" action and returns its "register_user" link.
"""
identity_provider = get_identity_provider_with_capability(
request.app["settings"], "register_user"
)
if identity_provider:
try:
register_user_endpoint = await identity_provider.get_endpoint(
"register-user"
)
except KeyError:
register_user_endpoint = await identity_provider.get_endpoint(
"register_user"
)
async with ClientSession() as session:
async with session.get(register_user_endpoint) as resp:
return {
**(await resp.json())["register_user"],
**{"url": register_user_endpoint},
}


async def _get_users(request: web.Request) -> Tuple[List[coreapi.Error], List[str]]:
"""Get users, if requester is root."""
try:
Expand All @@ -90,10 +62,6 @@ async def get_users(request: web.Request) -> web.Response:
"errors": errors,
}

register_user = await find_register_user_provider(request)
if register_user: # pragma: no cover # Needs a running kisee.
content["register_user"] = register_user

if last_element:
if request.rel_url.query:
if not request.rel_url.query.get("after"):
Expand Down