Skip to content

Fix URL pattern problem with hyphened domain names #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prtksxna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix URL pattern problem with hyphened domain names #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/io.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Various I/O based operations
class Caman.IO
# Used for parsing image URLs for domain names.
@domainRegex: /(?:(?:http|https):\/\/)((?:\w+)\.(?:(?:\w|\.)+))/
@domainRegex: /(?:(?:http|https):\/\/)((?:[a-zA-Z0-9_-]+)\.(?:(?:[a-zA-Z0-9_-]*|\.)+))/;

# Is the given URL remote?
# If a cross-origin setting is set, we assume you have CORS
Expand Down Expand Up @@ -110,4 +110,4 @@ Caman::toBase64 = (type = "png") ->
type = type.toLowerCase()
return @canvas.toDataURL "image/#{type}"

IO = Caman.IO
IO = Caman.IO