Christmas cleanup 2025 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation control; switch-constant-folding is constant-folding
There was a problem hiding this comment.
Pull request overview
This PR performs a "Christmas cleanup" for 2025, focusing on code quality improvements and enhanced compiler control features.
Key Changes:
- Improved layout/formatting of MulExp and RegionExp expressions with better indentation calculations
- Enhanced inlining and specialization control through
-max_inl_szand-max_spec_szflags - Added constant folding control via new
-cfoldflag - Fixed spelling errors ("aggressive_opt" vs "aggresive_opt")
- Updated manual documentation and bibliography
Reviewed changes
Copilot reviewed 33 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Runtime/Region.c | Converted C-style comments to C++ style, fixed format specifiers, contains spelling error |
| src/Runtime/Profiling.c | Updated format strings and added debug output for profiling info |
| src/Runtime/Math.c | Added runtime_test1auto function for testing multi-parameter passing |
| src/Compiler/Regions/RegionExp.sml | Improved SELECT expression layout with dynamic indentation |
| src/Compiler/Regions/MulExp.sml | Enhanced formatting and layout of declarations, improved code readability |
| src/Compiler/Regions/Effect.sml | Added short flag name "abbrev" for print_control_abbrev_layout |
| src/Compiler/Lambda/OptLambda.sml | Major refactoring: separated constant folding control, improved inlining logic, fixed "aggressive" typo |
| src/Compiler/Backend/X64/CodeGenX64.sml | Added clarifying comments about bytes vs words |
| src/Compiler/Backend/X64/CodeGenUtilX64.sml | Reorganized code structure, moved helper function |
| src/Common/KitReML.sml | Fixed flag name from "aggresive_opt" to "aggressive_opt" |
| src/Common/Flags.sml | Fixed flag name consistency (aggressive_opt) |
| kitdemo/*.sml | Formatting improvements and style cleanup across multiple demo files |
| doc/manual/*.tex | Added SML syntax highlighting support, updated macros |
| doc/manual/*.pdf | Regenerated PDF files with updated content |
| doc/manual/mlkit.bib | Added 5 new bibliography entries for recent publications |
| NEWS.md | Documented new inlining control and argument flattening features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| allocProfNowFin=0, // Words used on object descriptors in fin. regions. | ||
| maxAllocProfFin=0, // At time maxAllocFin how much were used on object descriptors. | ||
| maxAlloc=0, // Max. allocated data in both inf. and fin. regions. | ||
| // - not nessesarily equal to maxAllocInf+maxAllocFin!!! |
There was a problem hiding this comment.
Fixed typo in comment: "nessesarily" should be "necessarily"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-max_inl_szand-max_spec_sz).-no_cfoldis passed tomlkit.