Skip to content

Support range requests of the form bytes:-n #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annorax wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support range requests of the form bytes:-n #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,18 @@ var vidStreamer = function (req, res) {
if (range !== undefined && (range = range.match(/bytes=(.+)-(.+)?/)) !== null) {
// Check range contains numbers and they fit in the file.
// Make sure info.start & info.end are numbers (not strings) or stream.pipe errors out if start > 0.
info.start = isNumber(range[1]) && range[1] >= 0 && range[1] < info.end ? range[1] - 0 : info.start;
info.end = isNumber(range[2]) && range[2] > info.start && range[2] <= info.end ? range[2] - 0 : info.end;
if (isNumber(range[1]) && range[1] >= 0 && range[1] < info.end) {
info.start = range[1] - 0;
}
if (isNumber(range[2]) && range[2] > info.start && range[2] <= info.end) {
info.end = range[2] - 0;
}
info.rangeRequest = true;
} else if (range !== undefined && (range = range.match(/bytes=-(.+)/)) !== null) {
// Check that the requested number of bytes from the end of the file doesn't exceed the file size.
if (isNumber(range[1]) && range[1] > 0 && range[1] <= info.size) {
info.start = info.size - range[1];
}
info.rangeRequest = true;
} else if (reqUrl.query.start || reqUrl.query.end) {
// This is a range request, but doesn't get range headers. So there.
Expand Down