Add hover model (indicates current value being hovered)#40
Open
rcrisp wants to merge 1 commit intomelloc01:masterfrom
Open
Add hover model (indicates current value being hovered)#40rcrisp wants to merge 1 commit intomelloc01:masterfrom
rcrisp wants to merge 1 commit intomelloc01:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes adding a scope variable (
hoverModel) that binds the currently "hovered" value. It also switchesng-mouseenterto useng-mousemoveto determine stars being hovered. This allowed me to updated some of the "half star" logic so that half stars are shown in real time while the user is hovering. When I tried the test cases it would only show full stars and then a half star after it was clicked. This does create more scope digests though, as you can imagine. I'm not actually using half stars, so in my case ng-mouseenter would be more preferred. Perhaps in a future update this can automatically be determined and use the appropriate method.I figured I would include the update for half stars since and leave it at
mousemovesince I got to tinkering with it anyway. Let me know if there was a reason it was setup the way it was instead. I added an example of the hover model to theindex.htmlexample page.