Open
Conversation
Owner
|
Really interesting @whitef0x0, this is actually a great idea. Thinking in generalize it for a standalone font-awesome angular directive? I really like it! Will test it here: ] |
Contributor
Author
|
@melloc01 Yea for sure. Are you suggesting I make this into a fork of your module? |
Contributor
Author
|
It seems like there is already a general module for font awesome icon mapping http://picardy.github.io/angular-fontawesome/demo/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addition allows for font-awesome-icon mapping. The only caveat about this addition is that it requires a connection to the internet to work.
I'm thinking I should maybe add offline support as well? @melloc01 what do you think