Merged
Conversation
To enable agents in sdk-python, I needed two fixes: - Only run npm install if we have a package.json - Don't use a project file for uv run (as it's not needed for TS, and python would try to use the wrong project) Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
In order to better share code between browser and node integ tests, use a single implementation for creating clients and inside of the factory methods, do the conditional check for what environment we're running in. As part of this I refactored the setup to take advantage of vitest features of having the global setup inject data into the running tests - including whether we're running in the browser and if we're running in CI/CD. --------- Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Run all integ tests in both node & browser, using file naming to designate tests that require a specific environment. This effectively switches us from environment-opt-in (need to duplicate tests between X.test and X.browser.test to have common coverage) to opt-out (need to explicitly move tests to x.test.node if it's only supposed to run in node). Goal here is to reduce test duplication and improve compatibility between browser and node. Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
To make the GitHub Workflow logs more obvious/readable Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.