Skip to content

Conversation

@talonchandler
Copy link
Collaborator

Migrated from old recOrder #484.

  • this branch requires maintenance and testing before merging into recorder-merge or main
  • writes QLIPP-style reconstruction alongside new diffraction-aware vector-optics reconstruction
  • backwards compatible with the birefringence-and-phase.yml configuration file

@talonchandler talonchandler changed the base branch from recorder-merge to main July 12, 2025 20:34
@talonchandler
Copy link
Collaborator Author

@amitabhverma, this PR is ready for your review.

I've decided to leave the config files unchanged. The only thing that changes is the expected output:

  • if you request a "birefringence and phase" reconstruction, you will get a vector reconstruction alongside your scalar reconstruction
  • if you request a "birefringence" reconstruction only, you will only get a scalar birefringence reconstruction
  • if you request a "phase" reconstruction only, you will only get a scalar phase reconstruction

I have tested the reconstructions via CLI and via automated tests, so I don't expect major headaches.

- fixes #459
- tested GUI working as expected for vector reconstruction #440
amitabhverma
amitabhverma previously approved these changes Aug 15, 2025
Copy link
Collaborator

@amitabhverma amitabhverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks good to me. Nothing obvious came up.
  • Finished testing with the GUI and got expected output

fixes `WARNING: QPropertyAnimation::updateState...`
@talonchandler
Copy link
Collaborator Author

Tested and this is working well in the CLI and GUI. @amitabhverma you can approve and merge. Thank you!

@amitabhverma amitabhverma merged commit 4850e3f into main Aug 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants