Skip to content

Conversation

@amitabhverma
Copy link
Collaborator

- removed pyqt6 dependency
- streamline different setup needs to address #498
- added position metadata to info label #500
- bug report template to include relevant logs which are created next to the output dir, name of the dataset, yaml file(s) if encountering reconstruction errors
- CLI can be used without QtBindings (PyQT or PySide) but will show a warning
Copy link
Collaborator

@talonchandler talonchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested three installations and all behaved as I expected:

  1. pip install .. As expected, the CLI worked, the GUI did not (does not appear in CLI list, no napari available).
  2. pip install .[all]. As expected, both the CLI and GUI work.
  3. An existing napari installation. pip install napari[all] (installs PyQt5) then pip install .[all]. As expected, both the CLI and GUI work.

I left a few comments below. Also, please update the README and /docs installation instructions to reflect these changes.

- moved pycromanager and magicgui to [all] flag
- mostly applies when barebone recOrder is installed
- in order to lead a user to install the correct missing package (pycromanager)
@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 10.55%. Comparing base (7687259) to head (8369492).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
recOrder/plugin/tab_recon.py 0.00% 27 Missing ⚠️
recOrder/plugin/main_widget.py 0.00% 22 Missing ⚠️
recOrder/plugin/__init__.py 0.00% 6 Missing ⚠️
recOrder/acq/acq_functions.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main     mehta-lab/recOrder#503      +/-   ##
=========================================
+ Coverage   9.54%   10.55%   +1.01%     
=========================================
  Files         30       41      +11     
  Lines       4591     7364    +2773     
=========================================
+ Hits         438      777     +339     
- Misses      4153     6587    +2434     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talonchandler talonchandler self-requested a review February 19, 2025 20:36
Copy link
Collaborator

@talonchandler talonchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @amitabhverma. Just retested the tests I described above, and all's working. Merging.

@talonchandler talonchandler added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit c4fed09 Feb 19, 2025
7 checks passed
@talonchandler talonchandler deleted the pydantic-model-prototype-setup branch February 20, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants