-
Notifications
You must be signed in to change notification settings - Fork 4
remove pyqt6 dependency and re-worked setup cfgs #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- removed pyqt6 dependency - streamline different setup needs to address #498 - added position metadata to info label #500 - bug report template to include relevant logs which are created next to the output dir, name of the dataset, yaml file(s) if encountering reconstruction errors - CLI can be used without QtBindings (PyQT or PySide) but will show a warning
changed install flag to "all"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested three installations and all behaved as I expected:
pip install .. As expected, the CLI worked, the GUI did not (does not appear in CLI list, no napari available).pip install .[all]. As expected, both the CLI and GUI work.- An existing napari installation.
pip install napari[all](installsPyQt5) thenpip install .[all]. As expected, both the CLI and GUI work.
I left a few comments below. Also, please update the README and /docs installation instructions to reflect these changes.
- moved pycromanager and magicgui to [all] flag
- mostly applies when barebone recOrder is installed - in order to lead a user to install the correct missing package (pycromanager)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main mehta-lab/recOrder#503 +/- ##
=========================================
+ Coverage 9.54% 10.55% +1.01%
=========================================
Files 30 41 +11
Lines 4591 7364 +2773
=========================================
+ Hits 438 777 +339
- Misses 4153 6587 +2434 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @amitabhverma. Just retested the tests I described above, and all's working. Merging.
pip install recOrder-napariinstallnapari? waveorder#194