Skip to content

fix(api): only compress > 10kb #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GuillaumeDecMeetsMore merged 1 commit into from
Dec 1, 2025
Merged

fix(api): only compress > 10kb #404

GuillaumeDecMeetsMore merged 1 commit into from
Dec 1, 2025

Conversation

@GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Nov 28, 2025

Changed

  • In high network speed environments (e.g. k8s), it's sometimes not worth compressing compared to sending raw JSON.
    • Adapted compression layer so that it compresses only if the payload is bigger than 10KB, instead of the current default of 32 bytes

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Nov 28, 2025
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review November 28, 2025 09:09
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 38e0335 into master Dec 1, 2025
4 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/fix/api-only-compress-payloads-bigger-than-10kb branch December 1, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mm-derek mm-derek mm-derek approved these changes

@mm-zacharydavison mm-zacharydavison Awaiting requested review from mm-zacharydavison

Assignees

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeDecMeetsMore @mm-derek