Skip to content

fix: move telemetry to "warning" level + add timeouts and use non-blo… #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeDecMeetsMore merged 1 commit into from
Nov 19, 2025
Merged

fix: move telemetry to "warning" level + add timeouts and use non-blo… #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions bins/nittei/src/telemetry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use std::time::Duration;

use opentelemetry::{global, propagation::TextMapCompositePropagator, trace::TracerProvider};
use opentelemetry_datadog::{ApiVersion, DatadogPipelineBuilder, DatadogPropagator};
use opentelemetry_otlp::{WithExportConfig, WithHttpConfig};
Expand All @@ -14,7 +16,10 @@ use tracing_subscriber::{EnvFilter, Registry, layer::SubscriberExt};
/// It should only be called once!
pub fn init_subscriber() -> anyhow::Result<()> {
// Filter the spans that are shown based on the RUST_LOG env var or the default value ("info")
let env_filter = EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info"));
let env_filter = EnvFilter::try_from_default_env()
.unwrap_or_else(|_| EnvFilter::new("info"))
// Downgrade opentelemetry_sdk errors to warnings
.add_directive("opentelemetry_sdk=warn".parse()?);

// If the binary is compiled in debug mode (aka for development)
// use the compact format for logs
Expand Down Expand Up @@ -125,7 +130,8 @@ fn get_tracer_datadog(
config.sampler = Box::new(get_sampler());
config.id_generator = Box::new(RandomIdGenerator::default());

let http_client = reqwest::blocking::Client::new();
let http_client = get_http_client()?;

DatadogPipelineBuilder::default()
.with_http_client(http_client)
.with_service_name(service_name)
Expand All @@ -146,7 +152,7 @@ fn get_tracer_otlp(
service_version: String,
service_env: String,
) -> anyhow::Result<SdkTracerProvider> {
let http_client = reqwest::blocking::Client::new();
let http_client = get_http_client()?;
let otlp_exporter = opentelemetry_otlp::SpanExporter::builder()
.with_http()
.with_http_client(http_client)
Expand Down Expand Up @@ -192,3 +198,13 @@ fn get_sampler() -> Sampler {
// (2) if no parent, then the trace id ratio
Sampler::ParentBased(Box::new(Sampler::TraceIdRatioBased(ratio_to_sample)))
}

/// Get the HTTP client to be used
/// This is used to send traces to the tracing endpoint
fn get_http_client() -> anyhow::Result<reqwest::Client> {
reqwest::Client::builder()
.timeout(Duration::from_secs(10))
.connect_timeout(Duration::from_secs(5))
.build()
.map_err(|e| anyhow::anyhow!("Failed to create HTTP client for telemetry: {}", e))
}