[NO-ISSUE] refactor/improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| async fn configure_server(context: NettuContext) -> Result<(Server, u16), std::io::Error> { | ||
| let port = context.config.port; | ||
| let address = format!("0.0.0.0:{}", port); | ||
| let address = format!("127.0.0.1:{}", port); |
Collaborator
Author
There was a problem hiding this comment.
Might need to change this again when deploying, but for the moment, let's listen only on localhost interface (as any other app)
GuillaumeDecMeetsMore
changed the title
Collaborator
Author
|
I'll update the readme in a follow-up PR |
mm-zacharydavison
approved these changes
Jul 4, 2024
mm-zacharydavison
left a comment
mm-zacharydavison
left a comment
There was a problem hiding this comment.
LGTM but what are all the .sqlx files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
MakefiletoJustfilesqlx's offline mode files (docs)