replace np.alen since it is no longer in numpy #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsDu
reviewed
Oct 3, 2022
|
|
||
| def alen(x): | ||
| return 1 if np.isscalar(x) else len(x) | ||
|
|
There was a problem hiding this comment.
Might be better to use shape[0] to be clearer that this is supposed to return the length of the first dim.
|
@meeliskull any updates on this PR? Is this being actively maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy no longer contains the
alenfunction, but it is a trivial function to implement so I have replaced it with my own.