feat(na): cache docker image to make booting quicker#2170
Closed
mrjones-plip wants to merge 3 commits intomainfrom
Closed
feat(na): cache docker image to make booting quicker#2170mrjones-plip wants to merge 3 commits intomainfrom
mrjones-plip wants to merge 3 commits intomainfrom
Conversation
Contributor
Author
|
Maybe there's some other optimizations, but I'm rescinding this PR as the speed gain is nominal at best. Here's timings of running
Even changing the entry point from 🤷 |
Contributor
Author
|
Good news everybody! The version we're about to ship in #2152 seems to reduce compile time by ~1sec 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
Dockerfilethat runs theapk addcommands that we used to run every time you booted up the docker service. By caching this install command, the boot up time, and specifically the time to be able to start serving HTTP requests, is a lot less. This is especially true when developers (like me!) usedocker rm -f $(docker ps -qa)to frequently cull all running services.License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.