feat(#1782): documentation for cht-sync v2#1783
Conversation
|
Awesome! I'm excited to dive into this. Please take a moment to fill out the the ticket description to add a brief description of your changes and anything you'd like to draw attention to. |
mrjones-plip
left a comment
There was a problem hiding this comment.
Yay! So cool to seem more developer friendly changes along with what look to be real world experiences on tuning be codified in our docs - thank you!
See my requests below, but also I think it'd be nice to move the two near identical tuning sections to it's own page maybe? I don't feel too strongly, but we have slightly different wording in k8s vs docker on how to use threads and concurrency, and now need to keep them in sync when updating them.
maybe put all the tuning info on their own page and then add a "to configure in: k8s | docker" tab selection like we do in in the dev node setup section?
|
Oh yes! If we're going to deprecate the extra docker compose files with the awesome |
Co-authored-by: mrjones <8253488+mrjones-plip@users.noreply.github.com>
Ah - I've just discovered the I'm being a bit passive aggressive and fleshing out the body of this PR - feel free blow away with more current/accurate info! |
mrjones-plip
left a comment
There was a problem hiding this comment.
Ok! I took a little time to do some testing, got really stuck, and then discovered the v2 branch and got mostly unstuck 😅
I made some inline suggestions, but it's not clear how to set up the local dbt model directory. I got the local profile to work by just pointing it to a local git clone of the CHT Pipeline repo, but I think this isn't correct. I should have done a dbt init and then "add cht-pipeline as a dependency" per the docs, right?
I'm not quite sure how to weave it in (a bit of a chicken and egg here), but we should some how:
- add
dbtas a prerequisite for development (fordbt initetc) - give a sentence or two about what should be in the
DBT_LOCAL_PATHdirectory
Co-authored-by: mrjones <8253488+mrjones-plip@users.noreply.github.com>
added a new page 'Tuning dbt' and linked the two setup pages to it |
The thing with the local profile is it uses a volume with a path on the host and there's not a good way to set a default path or anything; file paths in docker compose must be absolute. So DBT_LOCAL_PATH, and a local dbt project, is required. It makes it a little harder to just get a local copy of cht-sync running without any custom models, because you can't just use the remote cht-pipeline repo with CHT_PIPELINE_BRANCH_URL. It needs at least an empty project. So I added "a dbt project" to prerequisites and changed wording to make this more clear. |
|
Thanks for implementing suggestions! I'll take another pass at trying to deploy locally today or tomorrow. I realize we don't cover the upgrade from v1 to v2. And...there's breaking changes, hence the major SemVer bump, yeah? Off the top of my head I can think of:
but I haven't read into a lot/most of the under the hood changes - these are breaking? We for sure should add an upgrade steps, and possibly list out what the breaking changes are? |
jkuester
left a comment
There was a problem hiding this comment.
Very nice! I def agree with mrjones that we should have at least some kind of migration guide for how to get from v1 to v2.
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
mrjones-plip
left a comment
There was a problem hiding this comment.
Great to see the comments on v1 -> v2 updating - thank you!
Do we want to bump the schema? I don't know how this is used so maybe not?
Also - so sorry for the delays in timely responses :(
I think this is close though :) !!
|
@mrjones-plip missed your last question, can you re-review so this can be merged?
Its not very well defined what this version is, and is just a default suggestion anyway. But to the extent that it is defined, its intended as the version of the data, not the code, so I don't think it should change here. |
mrjones-plip
left a comment
There was a problem hiding this comment.
What?! This was blocked on me this whole time 😭 - I'm sorry!
Let's ship this and fix anything folks find later - lgtm!
#1782
Docs for upcoming CHT Sync v2 release. This PR:
git)When following setup steps in this docs PR, be sure your CHT Sync repo is on the
v2branch per this PR. That will make sure the--profilelogic is added to the compose files and the.envcreated from the example on has the newDBT_LOCAL_PATHvalue.