feat: add instructions for setting up ECR repository#1780
Open
feat: add instructions for setting up ECR repository#1780
Conversation
mrjones-plip
requested changes
Feb 25, 2025
Contributor
mrjones-plip
left a comment
mrjones-plip
left a comment
There was a problem hiding this comment.
This is so great - thank you Josh!
I'm actually apparently pretty useless here - I only managed to really confuse myself as to how all this works - sorry! But hopefully, we'll be able to dive deeper in with this PR so we'll both come out ahead 🥇
Co-authored-by: mrjones <8253488+mrjones-plip@users.noreply.github.com>
Member
|
@jkuester what is the plan with this PR? Can we merge it? Does it need extra work? cc @Hareet @mrjones-plip |
Contributor
|
@andrablaj - I think we need clarity from @Hareet on which URLs are which. Oh - maybe @dianabarsan knows and could comment as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hoping to capture the main points from medic/cht-core#9685 in the most discoverable way possible to hopefully avoid similar confusion the next time we need to publish a new image.
I am operating with extremely limited knowledge of the specifics here 😅, so suggestions are very welcome regarding the content of these docs! Also, for what is is worth, I am not trying too hard to capture all the minor details here. I just want to record enough that someone with the right AWS access could figure out what they needed to do. (Happy to add/remove content as necessary to achieve this objective).
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.