fix(#10357): prevent DEBUG logs from appearing in production#10583
fix(#10357): prevent DEBUG logs from appearing in production#10583
Conversation
…y adding global log level in CI instead
|
This PR is now marked "stale" after 30 days without activity. It will be closed automatically in 10 days unless you add a comment, push new changes or remove the "stale" label. |
|
@jkuester Would appreciate a review on this. Thanks! |
jkuester
left a comment
There was a problem hiding this comment.
Thanks for keeping this going! Just a couple minor things and this should be good to go!
Can we also get a docs PR to update the log level documentation?
|
Another thing that is worth considering is if we should update the |
Actually, there is already a PR for this. medic/cht-docs#2030 |
mrjones-plip
left a comment
There was a problem hiding this comment.
Gotta question about the extra compose file!
jkuester
left a comment
There was a problem hiding this comment.
A couple minor suggestions around not reading the host LOG_LEVEL envar even for our test/development scripts. I am fine if you want to keep them as-is, but I just think it will be less complex to just hardcode the value (and might save some confusion in the future).
Summary
Fixes #10357 - DEBUG logs were appearing in production despite
NODE_ENV=production.Changes:
LOG_LEVELto'info'when not explicitly set in application codeLOG_LEVEL: 'debug'to CI workflow env (instead of repeating in each npm script).Values.sentinel.log_levelinstead of.Values.api.log_levelsentinel.log_levelandapi.log_leveldefaults tobase.yamlBased on
This PR is based on the work by @AmirSaudagar55 in #10376. Additional fixes were made to:
LOG_LEVEL=debugfrom npm scripts to CI workflow envCode review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.