Skip to content

feat(#10240): allow limit_count_to_goal in target configuration schema #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dianabarsan merged 3 commits into from
Apr 18, 2026
Merged

feat(#10240): allow limit_count_to_goal in target configuration schema #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abbaac7
fix(#10240): allow limit_count_to_goal in target configuration schema
cliftonmcintosh Mar 31, 2026
97842d4
fix: include limit_count_to_goal in compiled target output
cliftonmcintosh Mar 31, 2026
f4613eb
Merge branch 'main' into feat/10240-hide-target-counts-past-goal
cliftonmcintosh Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/compilation/validate-declarative-schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ const TargetSchema = joi.array().items(
.optional()
.error(targetError('idType should be either "report" or "contact" or "function(contact, report)"')),
aggregate: joi.boolean().optional(),
limit_count_to_goal: joi.boolean().optional(),
Copy link
Copy Markdown
Member

@dianabarsan dianabarsan Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this property name is quite verbose. I would rather keep it shorter like limit_count or max_count, but this is not very important.

Copy link
Copy Markdown
Contributor Author

@cliftonmcintosh cliftonmcintosh Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the limit_count_to_goal is more helpful at explaining what the limit is, and I've kept it as is, but please let me know if you want it changed. If so, I'll also need to update the other PRs.

})
)
.unique('id')
Expand Down
1 change: 1 addition & 0 deletions src/lib/parse-targets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ module.exports = projectDir => {
'dhis',
'visible',
'aggregate',
'limit_count_to_goal',
])),
};
};
Loading