Skip to content

fix: --local arg not working #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ernestoteo wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: --local arg not working #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b70c434
fix: --local arg not working
ernestoteo May 2, 2025
6a6ddf7
fix: --local arg not working
ernestoteo May 3, 2025
1d4c909
fix: test failing
ernestoteo May 3, 2025
f70939a
fix: npx cht --local not working
ernestoteo Jun 25, 2025
54cc477
fix: npx cht --local not working
ernestoteo Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/get-api-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const getApiUrl = (cmdArgs, env = {}) => {
// behaviour as it is connecting to.
// See ./archiving-db.js
instanceUrl = parseLocalUrl(env.COUCH_URL);
if (instanceUrl.hostname !== 'localhost') {
if (instanceUrl.hostname !== 'localhost' && instanceUrl.hostname !== '127.0.0.1') {
throw Error(
`--local was specified but COUCH_URL env var is set to '${instanceUrl.hostname}'. `
+ `Please use --url for remote servers.`
Expand Down Expand Up @@ -55,10 +55,10 @@ const parseLocalUrl = (couchUrl) => {
const doParse = (unparsed) => {
const parsed = new url.URL(unparsed);
parsed.path = parsed.pathname = '';
parsed.host = `${parsed.hostname}:5988`;
parsed.host = parsed.hostname.includes('localhost')? `127.0.0.1:5988`: `${parsed.hostname}:5988`;
return new url.URL(url.format(parsed));
};

if (couchUrl) {
info(`Using local url from COUCH_URL environment variable: ${couchUrl}`);
return doParse(couchUrl);
Expand Down
13 changes: 9 additions & 4 deletions test/lib/get-api-url.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ describe('get-api-url', () => {

it('use environment variable', () => {
const actual = apiUrlLib.getApiUrl({ local: true }, { COUCH_URL: 'http://user:pwd@localhost:5984/db' });
expect(actual).to.deep.equal(new url.URL('http://user:pwd@localhost:5988/medic'));
expect(actual).to.deep.equal(new url.URL('http://user:pwd@127.0.0.1:5988/medic'));
});

it('use environment variable 127.0.0.1', () => {
const actual = apiUrlLib.getApiUrl({ local: true }, { COUCH_URL: 'http://user:pwd@127.0.0.1:5984/db' });
expect(actual).to.deep.equal(new url.URL('http://user:pwd@127.0.0.1:5988/medic'));
});

it('warn if environment variable targets remote', () => {
Expand Down Expand Up @@ -68,13 +73,13 @@ describe('get-api-url', () => {
describe('parseLocalUrl', () => {
const parseLocalUrl = apiUrlLib.__get__('parseLocalUrl');
it('basic', () =>
expect(parseLocalUrl('http://admin:pass@localhost:5988/medic').href).to.eq('http://admin:pass@localhost:5988/'));
expect(parseLocalUrl('http://admin:pass@localhost:5988/medic').href).to.eq('http://admin:pass@127.0.0.1:5988/'));

it('updates port', () =>
expect(parseLocalUrl('http://admin:pass@localhost:5984/medic').href).to.eq('http://admin:pass@localhost:5988/'));
expect(parseLocalUrl('http://admin:pass@localhost:5984/medic').href).to.eq('http://admin:pass@127.0.0.1:5988/'));

it('ignores path', () =>
expect(parseLocalUrl('http://admin:pass@localhost:5984/foo').href).to.eq('http://admin:pass@localhost:5988/'));
expect(parseLocalUrl('http://admin:pass@localhost:5984/foo').href).to.eq('http://admin:pass@127.0.0.1:5988/'));
});

describe('isLocalhost', () => {
Expand Down