Skip to content

Replace deprecated LinkBegin hook to TitleIsAlwaysKnown #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szotsaki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated LinkBegin hook to TitleIsAlwaysKnown #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Wikilog.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
$wgHooks['ArticleFromTitle'][] = 'Wikilog::ArticleFromTitle';
$wgHooks['ArticleViewHeader'][] = 'Wikilog::ArticleViewHeader';
$wgHooks['BeforePageDisplay'][] = 'Wikilog::BeforePageDisplay';
$wgHooks['LinkBegin'][] = 'Wikilog::LinkBegin';
$wgHooks['TitleIsAlwaysKnown'][] = 'Wikilog::TitleIsAlwaysKnown';
$wgHooks['SkinTemplateTabAction'][] = 'Wikilog::SkinTemplateTabAction';
$wgHooks['SkinTemplateTabs'][] = 'Wikilog::SkinTemplateTabs';
$wgHooks['SkinTemplateNavigation'][] = 'Wikilog::SkinTemplateNavigation';
Expand Down Expand Up @@ -376,25 +376,23 @@ static function BeforePageDisplay( $output, $skin ) {
}

/**
* LinkBegin hook handler function:
* TitleIsAlwaysKnown hook handler function:
* Links to threaded talk pages should be always "known" and
* always edited normally, without adding the sections.
*/
static function LinkBegin( $skin, $target, $text, $attribs, $query, &$options, &$ret )
static function TitleIsAlwaysKnown( $title, &$isKnown )
{
if ( $target->isTalkPage() &&
( $i = array_search( 'broken', $options ) ) !== false ) {
if ( self::nsHasComments( $target ) ) {
array_splice( $options, $i, 1 );
$options[] = 'known';
if ( $title->isTalkPage() && $isKnown) {
if ( self::nsHasComments( $title ) ) {
$isKnown = true;
}
}
return true;
}

/**
* SkinTemplateTabAction hook handler function.
* Same as Wikilog::LinkBegin, but for the tab actions.
* Same as Wikilog::TitleIsAlwaysKnown, but for the tab actions.
*/
static function SkinTemplateTabAction( $skin, $title, $message, $selected, $checkEdit, &$classes, &$query, &$text, &$result )
{
Expand Down