Change deprecated onArticleSave on onPageContentSave#27
Open
Albul wants to merge 4 commits intomediawiki4intranet:masterfrom
Open
Change deprecated onArticleSave on onPageContentSave#27Albul wants to merge 4 commits intomediawiki4intranet:masterfrom
Albul wants to merge 4 commits intomediawiki4intranet:masterfrom
Conversation
…ring given in Wikilog.php on line 388
vitalif
reviewed
Feb 24, 2019
| $this->mItemName = null; | ||
| $this->mItemTitle = null; | ||
| $this->mItemTalkTitle = null; | ||
| } |
Member
There was a problem hiding this comment.
Can you please keep tabs like in the original?) I'm not the fan of tabs over spaces, but I don't like a mix of both :)
vitalif
reviewed
Feb 24, 2019
| { | ||
| if ( $target->isTalkPage() && | ||
| ( $i = array_search( 'broken', $options ) ) !== false ) { | ||
| ( $i = array_search( 'broken', array_keys($options) ) ) !== false ) { |
Member
There was a problem hiding this comment.
Use isset( $options['broken'] ) instead of array_search(array_keys())
There was a problem hiding this comment.
As I see, $i is needed for an offset later, in array_splice
vitalif
reviewed
Feb 24, 2019
| //if ( $this->mShowEditLink && $item->mTitle->quickUserCan( 'edit' ) ) { | ||
| // $heading = $this->doEditLink( $item->mTitle, $item->mName ) . $heading; | ||
| //} | ||
| $heading = Xml::tags( 'h2', null, $heading ); |
| } else { | ||
| $query->setCategory('News'); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change deprecated onArticleSave on onPageContentSave https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSave