CAPTCHA: getForm: Update for change to ConfirmEdit#18
Open
mattflaschen wants to merge 1 commit intomediawiki4intranet:masterfrom
Open
CAPTCHA: getForm: Update for change to ConfirmEdit#18mattflaschen wants to merge 1 commit intomediawiki4intranet:masterfrom
mattflaschen wants to merge 1 commit intomediawiki4intranet:masterfrom
Conversation
Member
|
As I understand it will become incompatible with all releases up to 1.27 with this change? |
Author
|
Yes. ConfirmEdit has to have getFormInformation for it to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://phabricator.wikimedia.org/T141300 and
https://gerrit.wikimedia.org/r/301147
Fixes #17
Since this does not support latest MW core master, or the latest MW core release, I did not test it (I got wfMsg errors which made me realize it didn't support core master). It should work, though, or with trivial changes, since this is the same approach we're using in other places.