Open
Conversation
dericed
requested changes
Jul 31, 2017
Collaborator
dericed
left a comment
dericed
left a comment
There was a problem hiding this comment.
I suggest that the existing values maintain their names, while the new post adjustment values get their own new names.
Change names of loudness variables to reflect output values. Oh, and also make it so it isn’t broken.
Contributor
Author
|
Made suggested changes as well as fixed general brokenness (not sure why I thought that was working in the first place!) Before merge, please test on your end and see if I missed something (as well as the email report as I am having trouble testing that on this machine for some reason). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes email reports from ingestfile report post normalization loudness info.
I have been able to test this to the point of seeing that normalizaton is happening correctly and that the correct metadata is being stored in the capture log, however, there is something wrong with email reporting on my system. This could probably benefit from some testing on a CUNY setup, but I think it works.