Support story sample endpoint #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(test failures are expected, because |
pgulley
approved these changes
Jun 9, 2025
philbudne
approved these changes
Jun 9, 2025
fix unit tests
…ud/api-client into feature-sample-endpoint
Contributor
Author
|
(rebased to run full CI unit test suite) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new
story/sampleendpoint. Includes unit tests. Verified against staging server. This defaults to using all the data fields.Optimistic change: this includes an
expandedparam on the method, which if set toTruetried to include thetextfield. Not implemented on web server yet, but thought to add it so we don't need to spin a new release whenever that gets added. Is that a poor choice to include optimistically like this?