Skip to content

Fix some Turtle WoW skins#95

Open
doorknob6 wants to merge 2 commits intome0wg4ming:masterfrom
doorknob6:master
Open

Fix some Turtle WoW skins#95
doorknob6 wants to merge 2 commits intome0wg4ming:masterfrom
doorknob6:master

Conversation

@doorknob6
Copy link

@doorknob6 doorknob6 commented Mar 10, 2026

Fix Turtle WoW skins

This PR fixes some pfUI skins for Turtle WoW

Character menu title dropdown

This fixes the character menu title dropdown not being skinned properly.

A relatively straight-forward fix.
The dropdown was renamed in FrameXML from 'TWTitles' to 'PaperDollFrameTitlesDropdown'.

The fix is implemented in the turtle-wow module.

Inspect frame talent tab button positioning

Fixes inspect frame talent tab button positioning on higher screen resolutions by using the scaled border size.

Turtle WoW skin locations

Question is, should all custom Turtle WoW skins, abilities and behaviour remain in the turtle-wow module?

This fixes the character menu title dropdown not being skinned properly.
Fixes inspect frame talent tab button positioning on high resolutions.
@doorknob6 doorknob6 changed the title Fix character menu title dropdown skin Fix some Turtle WoW skins Mar 10, 2026
@K0lonel
Copy link

K0lonel commented Mar 10, 2026

You might want to take a look at jrc13245/pfUI-addonskinner also

@doorknob6
Copy link
Author

Good one, I've looked into it, but it seems that's mainly focused on third party addons. Not the FrameXML provided by the Turtle client.

I've got a few more skins functional in https://github.com/doorknob6/pfUI-turtle.

The only reason I made that addon was because Shagu preferred not having Turtle WoW custom content in his addon.
Seeing as this addon is the Turtle WoW edition, it might be a good idea to merge the skins into this addon.

@me0wg4ming
Copy link
Owner

me0wg4ming commented Mar 10, 2026

I can look into that after i merged experiment into master, coming saturday and sunday is my last test in 2 x 40 man raids before i will push experiment into master.

I´m super happy with the performance already but i wanna be sure

@me0wg4ming me0wg4ming added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants