Open
Conversation
This fixes the character menu title dropdown not being skinned properly.
Fixes inspect frame talent tab button positioning on high resolutions.
|
You might want to take a look at jrc13245/pfUI-addonskinner also |
Author
|
Good one, I've looked into it, but it seems that's mainly focused on third party addons. Not the FrameXML provided by the Turtle client. I've got a few more skins functional in https://github.com/doorknob6/pfUI-turtle. The only reason I made that addon was because Shagu preferred not having Turtle WoW custom content in his addon. |
Owner
|
I can look into that after i merged experiment into master, coming saturday and sunday is my last test in 2 x 40 man raids before i will push experiment into master. I´m super happy with the performance already but i wanna be sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Turtle WoW skins
This PR fixes some pfUI skins for Turtle WoW
Character menu title dropdown
This fixes the character menu title dropdown not being skinned properly.
A relatively straight-forward fix.
The dropdown was renamed in FrameXML from 'TWTitles' to 'PaperDollFrameTitlesDropdown'.
The fix is implemented in the turtle-wow module.
Inspect frame talent tab button positioning
Fixes inspect frame talent tab button positioning on higher screen resolutions by using the scaled border size.
Turtle WoW skin locations
Question is, should all custom Turtle WoW skins, abilities and behaviour remain in the turtle-wow module?