actionbar: custom icon size ratio#122
Open
dbulatovicx32 wants to merge 1 commit intome0wg4ming:masterfrom
Open
actionbar: custom icon size ratio#122dbulatovicx32 wants to merge 1 commit intome0wg4ming:masterfrom
dbulatovicx32 wants to merge 1 commit intome0wg4ming:masterfrom
Conversation
- added option to individually set height and width of an icon, rather than just setting the size for both - modified BarLayoutSize to allow new values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, as the other fork is stale I will propose few changes that didn't get merged in the main repo, please merge or discard as you see fit.
One thing that might be worth looking into is how to keep the icon image ratio itself, rather than letting it squish like in the screenshots, it doesn't bother me personally, but it might bother you.
Default, using only Icon Size of 50:
Custom Size, using width:50, height:30:
Drag background is correctly scaled as well:
