Skip to content

Ruby3 fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
m3ta4a wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Ruby3 fixes #6

m3ta4a wants to merge 71 commits into from

Conversation

@m3ta4a
Copy link

@m3ta4a m3ta4a commented Apr 28, 2022

No description provided.

randycoulman and others added 30 commits May 4, 2015 11:34
@randycoulman
Get specs passing with rspec 2.10
2ac9319
@randycoulman
Run with ActiveRecord 3 only
90578c0
@randycoulman
Use new Rspec Rake task and newer bundler gem tasks
d521637
@randycoulman
Remove Rails 2 references; bump verison to 0.3.0
c48447e
@randycoulman
Update minimum Ruby version; using new hash syntax
1436088
@randycoulman
Split tests and spec_helper into separate files
f5068a1
@randycoulman
Allow children relation options to be specified
8a6fb6c
@randycoulman
Protect ancestry_string against sql injection and ancestry_string for…
b33071d 
…matting errors
@randycoulman
Rename ancestry_string -> materialized_path
c353fbf
@randycoulman
Better handle hierarchies of unsaved objects
35db478
@randycoulman
Handle the case where a child's parent is changing to an unsaved node
dc7ab5b
@randycoulman
Don't allow a null materialized_path to be persisted
77551dc
@randycoulman
Only apply ancestry changes to children after an update, not a create
ea0bb3a 
We were checking `persisted?`, which is always true in an `after_save` callback.
@randycoulman
Minor cleanups and new specs
8905cab
@randycoulman
Allow the parent relation to be customized
61894bc
@randycoulman
Add relation customization documentation to the README
17e0c13
@randycoulman
Remove support for AR 3.0
d4d1c20
@randycoulman
Update AR dependency in the gemspec to 3.1
18e4d9d
@randycoulman
Keep ancestor_ids from erroring on a newly-created model
2bee717
@randycoulman
Arboreal models now understand root?
ce78ccf
@randycoulman
Optimize root by taking advantage of new root? method
559ce5e
@randycoulman
Merge pull request #1 from mavenlink/mavenlink_upgrades
4e0abee 
Mavenlink upgrades
@randycoulman
Add an ancestry_depth query
7f2e03e
@CacheFactory
remove with_exclusive_scope
32384cd
@CacheFactory
travis should build the 4.1 version
76de42d
@CacheFactory
inverse_of was breaking cache clearing behavior
02817e2
@CacheFactory
fix another rails4 issue; add back inverses and use parent_id presenc…
766d7c6 
…e check
Adding check for parent when populating materialized path
207b4e7
@CacheFactory
Merge pull request #2 from mavenlink/add_ancestry_depth
b4dfe89 
Add an ancestry_depth query
@naiyt
Merge branch 'master' into rails4
eb305a9
shirish-pampoorickal and others added 30 commits July 8, 2015 14:36
@shirish-pampoorickal
Fixed formatting issue
2269d14
@shirish-pampoorickal
Replace unnecessary gsub with sub
4807c24
@shirish-pampoorickal
Updated root method as per code review
8fb9ccf
Merge remote-tracking branch 'origin/add_optional_root_relation' into…
54cbd39 
… rails4
removes with_exclusive_scope
ae0f04c
@shirish-pampoorickal
Fixed failures on ActiveRecord-4.1.12
a6729ad
Merge pull request #4 from mavenlink/add_optional_root_relation
0706a84 
Add option to enable `root_ancestor` relation
@naiyt
Merge pull request #3 from mavenlink/rails4
26409fc 
Rails4 Compatability
@shirish-pampoorickal
Fixed issue with root_ancestor_id of descendants being set as nil whe…
0c0741c 
…n a child node is made a root
@shirish-pampoorickal
Updated spec to use map instead of pluck to be compatible with Active…
d3bdaa8 
…Record-3.1 in Ruby 1.9.3
Merge pull request #5 from mavenlink/fix_ancestry_depth_for_multi_lev…
b605aec 
…el_stories

Update root_ancestor_id of descendants when parent is made a root
@shirish-pampoorickal
Drop support for Ruby versions < 2.3.0
b2076ca
@shirish-pampoorickal
Drop support for ActiveRecord & ActiveSupport versions < 4.1
07f6e4c
@shirish-pampoorickal
Bump sqlite3 gem to version 1.3.13
0990624
@shirish-pampoorickal
Address deprecation warning for Rspec 2.99.0
4115d1e
@shirish-pampoorickal
Upgrade specs to expect syntax of rspec
c2feb4d
@shirish-pampoorickal
Upgrade Rspec to version 3.8.0
8556dcb
@shirish-pampoorickal
Add activerecord-4.2 gemfile and drop 3.1 & 3.2 versions
6c5c94d
@shirish-pampoorickal
Drop support for Rails 4.1 & add support for Rails 5.0
9e5c847
@shirish-pampoorickal
Add support for ActiveRecord 5.1.7
e4db3dc
@shirish-pampoorickal
Fix migrations in specs to work with Rails 5.1 & above
cf0c002
@shirish-pampoorickal
Add support for activerecord version 5.2.3
d453229
@shirish-pampoorickal
Run specs in relevant ruby versions
f2442f1
@shirish-pampoorickal @a-bates @naganowl
Drop support for Ruby version 2.1.10
9561203 
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@shirish-pampoorickal @a-bates @naganowl
Update after callback methods with backward compatible dirty attribut…
01aeb19 
…e method accessors

Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@shirish-pampoorickal @a-bates @naganowl
Move CompatibleActiveRecord module out of arboreal
cfe3005 
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@shirish-pampoorickal @a-bates @naganowl
Bump ruby version to 2.4.7
9feb3b0 
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@shirish-pampoorickal @a-bates @naganowl
Bump version to 0.4.0
e3fb4a2 
Co-authored-by: Andrew Bates <abates@mavenlink.com>
Co-authored-by: Alan Wong <alan@mavenlink.com>
@a-bates
Merge pull request #9 from mavenlink/drop_rails_3_x_support
8151990 
Drop Rails 3.x support
@m3ta4a
Fix configuring belongs_to class_name with keyword arguments instead …
5c02cb1 
…of a hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@m3ta4a @naiyt @shirish-pampoorickal @randycoulman @CacheFactory @a-bates