Skip to content

Conversation

@kanekosh
Copy link
Contributor

@kanekosh kanekosh commented Oct 31, 2025

Purpose

I realized that the engine data files (.npy) were not included in the package, so when we install openconcept from PyPI and try to run examples that requires engine data file (e.g. B738_sizing.py), it fails saying that engine .npy files are not found. I guess we've overlooked this because it works fine when owe git clones the repo and install with -e, which is also what GHA build does. (or Python packaging might have changed recently? Not exactly sure).

This PR fixes setup.py to include the engine data files to the package so pip-installing from PyPI installs these files.

To test it out, I added a block to the GHA build to install openconcept in a clean environment and checks if there exists engine .npy files in the installed package. It looks like it's working, but we can't directly verify the PyPI installation until we merge this PR and deploy a new version to PyPI.

I'm also ok with removing the new block in GHA as it doesn't look very neat.

Expected time until merged.

Soon

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)

Testing

See above

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.05%. Comparing base (e304402) to head (38b29e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         103      103           
  Lines       10729    10729           
=======================================
  Hits         8804     8804           
  Misses       1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kanekosh kanekosh changed the title Add engine data files to the package Fix setup.py to include engine data files to the package Nov 1, 2025
@kanekosh kanekosh marked this pull request as ready for review November 1, 2025 13:39
@kanekosh kanekosh requested a review from a team as a code owner November 1, 2025 13:39
@kanekosh kanekosh requested a review from sabakhshi November 1, 2025 13:39
sabakhshi
sabakhshi previously approved these changes Nov 3, 2025
@kanekosh kanekosh merged commit 0c2f844 into main Nov 3, 2025
7 of 8 checks passed
@kanekosh kanekosh deleted the fix-engine-data branch November 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants