Fix setup.py to include engine data files to the package #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I realized that the engine data files (.npy) were not included in the package, so when we install openconcept from PyPI and try to run examples that requires engine data file (e.g. B738_sizing.py), it fails saying that engine .npy files are not found. I guess we've overlooked this because it works fine when owe git clones the repo and install with -e, which is also what GHA build does. (or Python packaging might have changed recently? Not exactly sure).
This PR fixes setup.py to include the engine data files to the package so pip-installing from PyPI installs these files.
To test it out, I added a block to the GHA build to install openconcept in a clean environment and checks if there exists engine .npy files in the installed package. It looks like it's working, but we can't directly verify the PyPI installation until we merge this PR and deploy a new version to PyPI.
I'm also ok with removing the new block in GHA as it doesn't look very neat.
Expected time until merged.
Soon
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
See above
Checklist
Put an
xin the boxes that apply.