-
Notifications
You must be signed in to change notification settings - Fork 38
Fix erasure of Integrator subsytem, remove OpenMDAO upper bound #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 82.04% 82.05%
=======================================
Files 103 103
Lines 10724 10729 +5
=======================================
+ Hits 8799 8804 +5
Misses 1925 1925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Failing tests are being caused by pyCycle, I've opened this PR to fix the issue |
|
@kanekosh OpenMDAO/pyCycle#109 is now merged, but we need to wait for a new pyCycle release to be made before our tests will pass |
|
This should be good to go now @kanekosh shall we also bump the version? |
Purpose
Fixes OpenMDAO/OpenMDAO#3621, making OpenConcept compatible with latest version of OpenMDAO.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.