Skip to content

Conversation

@A-CGray
Copy link
Member

@A-CGray A-CGray commented Jul 11, 2025

Purpose

Addresses #70

  • Update to latest versions of black and flake8
  • Update to running all style checks on ubuntu 24 & python 3.11
  • Also run flake8 on python 3.13

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner July 11, 2025 20:24
@A-CGray A-CGray requested review from eirikurj and marcomangano and removed request for a team July 11, 2025 20:24
@A-CGray A-CGray linked an issue Jul 11, 2025 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. This will trigger a series of failures until we update all the downstream repos, correct?

@eirikurj
Copy link
Contributor

Yeah, this will trigger failure on pretty much all our repos

@A-CGray
Copy link
Member Author

A-CGray commented Jul 22, 2025

Yeah it will. I wonder if we should wait a couple of weeks and make fixing these formatting issues and the associated PRs an MDOLab workshop task. Might be a good introduction to our GitHub process for the new students?

@A-CGray
Copy link
Member Author

A-CGray commented Aug 28, 2025

Closing as we switched to ruff for formatting and linting in #74

@A-CGray A-CGray closed this Aug 28, 2025
@A-CGray A-CGray deleted the ModernStyle branch August 28, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update flake8 and black

4 participants