feat: Editorial review — Related website sets docs by chrisdavidmills · Pull Request #30654 · mdn/content

chrisdavidmills · 2023-11-30T08:19:18Z

Description

#30500 contains the engineering technical review for my work on Storage Access API and related website sets docs, which has been completed and approved. Thank you to @cfredric and @tunetheweb for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.

Background information

Related website sets is a part of Chrome's privacy sandbox project. It provides progressive enhancement for The Storage Access API, allowing the definition of a set of related, trusted sites that can receive automatic permission to access third party cookies originating from the set.

This PR aims to do the following:

Write a Related website sets page, nested under the Storage Access API page.
Document the Chrome-only Document.requestStorageAccessFor() method and add mentions and links in appropriate places
Update the main Storage Access API page to mention the above and provide an up-to-date picture of the API
Update the Using the Storage Access API page to include details of the above.
Update mentions of "first-party sets" to "related website sets"
Update permissions API information to include the top-level-storage-access permission feature name specific to requestStorageAccessFor(), and make sure the storage-access feature is marked as supported in Fx.

Motivation

Additional details

Related issues and pull requests

…tent into related-website-sets

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

chrisdavidmills · 2023-12-19T13:56:54Z

@teoli2003 thanks for the fabulous review! I have responded to all your comments, so the bulk of the content is now ready for another run through.

I've also added some new information about .well-known file requirements and security to the related website sets document. I only found this information very recently.

teoli2003

👍

* Related website sets docs * Rest of required content * Fix broken link * Updated status for RWS * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/privacy/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix description list linter mess * Fixes for cfredric tech review comments * address cfredric and tunetheweb feedback * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> * More tinkering with descriptions * more small tweaks, link fix * Fix quote style - single to double * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/http/cookies/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/hasstorageaccess/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * responding to the rest of teoli2003s comments * Add RWS well-known file and security information --------- Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

chrisdavidmills and others added 30 commits November 24, 2023 13:13

Related website sets docs

ae48e0a

Merge branch 'main' into related-website-sets

1d98073

Rest of required content

7a00819

Merge branch 'main' into related-website-sets

0992c1c

Fix broken link

4d2b90f

Merge branch 'related-website-sets' of github.com:chrisdavidmills/con…

a57d3e4

…tent into related-website-sets

Updated status for RWS

47cfab3

Merge branch 'main' into related-website-sets

09bdcb8

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

e425412

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

c2ff67d

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/index.md

3ad1838

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/index.md

9b695ce

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/index.md

2aeff35

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/index.md

05451cf

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/privacy/index.md

ff9f8e0

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

32e5f26

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Merge branch 'main' into related-website-sets

f5e45ca

Fix description list linter mess

60457c1

Fixes for cfredric tech review comments

dbdbea7

Merge branch 'main' into related-website-sets

000f16c

address cfredric and tunetheweb feedback

2ea9508

Update files/en-us/web/api/storage_access_api/using/index.md

908b73e

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/using/index.md

a083f0c

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/using/index.md

10d8db2

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/storage_access_api/using/index.md

81c4df0

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

e61854e

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

b8afb84

Co-authored-by: Chris Fredrickson <cfredric@users.noreply.github.com>

Merge branch 'main' into related-website-sets

281db89

More tinkering with descriptions

e3a0533

more small tweaks, link fix

d396b59

chrisdavidmills and others added 21 commits December 19, 2023 10:30

Update files/en-us/web/api/storage_access_api/index.md

e778e23

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

d767dc2

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

7a95e39

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

648defa

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

c68dc7c

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

9d90807

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

3ba30b1

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

ef17ee2

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

e598c6d

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/storage_access_api/index.md

86ce04c

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/hasstorageaccess/index.md

d535503

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccess/index.md

5f4f3b2

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccess/index.md

a8c0d95

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

d094c39

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

2275548

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

2861818

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

a00bc12

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Update files/en-us/web/api/document/requeststorageaccessfor/index.md

9f05d43

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Merge branch 'main' into related-website-sets

fb976d2

responding to the rest of teoli2003s comments

b7515f4

Add RWS well-known file and security information

14dc039

chrisdavidmills requested a review from teoli2003 December 19, 2023 13:54

Merge branch 'main' into related-website-sets

7e1878c

teoli2003 approved these changes Dec 20, 2023

View reviewed changes

teoli2003 merged commit 65f4a29 into mdn:main Dec 20, 2023

chrisdavidmills deleted the related-website-sets branch December 20, 2023 09:01

skyclouds2001 mentioned this pull request Dec 22, 2023

Add mdn_url for Document.requestStorageAccessFor() mdn/browser-compat-data#21718

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Editorial review — Related website sets docs#30654

feat: Editorial review — Related website sets docs#30654
teoli2003 merged 68 commits intomdn:mainfrom
chrisdavidmills:related-website-sets

chrisdavidmills commented Nov 30, 2023

Uh oh!

chrisdavidmills commented Dec 19, 2023

Uh oh!

teoli2003 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chrisdavidmills commented Nov 30, 2023

Description

Background information

Motivation

Additional details

Related issues and pull requests

Uh oh!

chrisdavidmills commented Dec 19, 2023

Uh oh!

teoli2003 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants