perf: iterate over CardPlay without allocation#4
Merged
mdgoldberg merged 1 commit intomainfrom Jan 18, 2026
Merged
Conversation
mdgoldberg
force-pushed
the
perf/cardplay-iter
branch
from
846f79d to
91e9edb
Compare
mdgoldberg
force-pushed
the
perf/cardplay-iter
branch
from
91e9edb to
486355e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardPlay::cards()iterator +CardPlayCardsto_vec()delegating to the iterator for compatibilitycargo test -p typesandcargo test -p strategies