Add support for vector deserialization#25
Merged
astinz merged 1 commit intomcxross:masterfrom Oct 2, 2025
Merged
Conversation
d-mooers
commented
Sep 25, 2025
lib/src/commonMain/kotlin/xyz/mcxross/kaptos/serialize/MoveVectorSerializer.kt
Outdated
Show resolved
Hide resolved
d-mooers
force-pushed
the
vector-deserialization
branch
from
52625bd to
9d11861
Compare
The tests here revealed an issue with the underlying bcs library, such that this only works for vectors under length 128. I will be following up with a PR to the bcs library
d-mooers
force-pushed
the
vector-deserialization
branch
from
9d11861 to
39c53f8
Compare
astinz
added a commit
that referenced
this pull request
Feb 2, 2026
Add support for vector deserialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests here revealed an issue with the underlying bcs library, such that this only works for vectors under length 128.
The bcs library does not properly decode vector length as a uleb, it instead treats it as a signed byte.
I will be following up with a PR to the bcs library, once the bcs library is patched.
Closes #22