Skip to content

Conversation

@rajivr
Copy link
Contributor

@rajivr rajivr commented Dec 7, 2019

sha512.c is needed by curve22519.c. By having sha512.c support in ext/mbedtls-asn1, we can do away with the requirement of having to import mbedtls into our tree just for sha512.c support.

As per PR #567, the imported mbedtls files are from mbedtls LTS version 2.16.3.

`sha512.c` is needed by `curve22519.c`. By having `sha512.c` support in
`ext/mbedtls-asn1`, we can do away with the requirement of having to import
mbedtls into our tree just for `sha512.c` support.

As per PR#567, the imported mbedtls files are from mbedtls LTS version 2.16.3.

Signed-off-by: Rajiv Ranganath <rajiv.ranganath@atihita.com>
@utzig
Copy link
Member

utzig commented Dec 9, 2019

we can do away with the requirement of having to import mbedtls into our tree just for sha512.c support.

Are you using tinycrypt for the sha256? This does not include any changes to build scripts, which means sha512.c will only stay there without use (for most users); or are you planning on also adding the build changes?

@rajivr
Copy link
Contributor Author

rajivr commented Dec 9, 2019

Are you using tinycrypt for the sha256?

Yes, I think so. I am still working on the port and here is how our mcuboot_config.h looks.

This does not include any changes to build scripts, which means sha512.c will only stay there without use (for most users); or are you planning on also adding the build changes?

I was not planning on making any changes to the build scripts. However, if there is interest upstream in adding enc_ec256 + sig_ed25519 configuration to build.rs without mbedtls, I can submit another PR enabling that configuration.

We are using Rust as well so I am somewhat familiar with build.rs, but not the rest of the simulator code

@rajivr
Copy link
Contributor Author

rajivr commented Jan 7, 2020

Closing in favor of #627

@rajivr rajivr closed this Jan 7, 2020
@rajivr rajivr deleted the for-upstream-01 branch January 7, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants